fix(framework): fix how pytorch DataContainer convert GPU tensor #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2739 +/- ##
=======================================
Coverage 70.30% 70.30%
=======================================
Files 131 131
Lines 10129 10129
=======================================
Hits 7121 7121
Misses 3008 3008
|
aarnphm
reviewed
Jul 13, 2022
| @@ -144,7 +144,7 @@ def to_payload( # pylint: disable=arguments-differ | |||
| batch_dim: int = 0, | |||
| plasma_db: "ext.PlasmaClient" | None = Provide[BentoMLContainer.plasma_db], | |||
| ) -> Payload: | |||
| batch = batch.numpy() | |||
| batch = batch.cpu().numpy() | |||
There was a problem hiding this comment.
we probably want to do this depending on the devices via CUDA_VISIBLE_DEVICES itself.
There was a problem hiding this comment.
I think it's not nessesary now. It only take 10 us if it is already on cpu
bojiang
approved these changes
Jul 14, 2022
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.