feat: added generic proto file for grpc service #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
reviewed
Jul 13, 2022
aarnphm
reviewed
Jul 13, 2022
There was a problem hiding this comment.
A few early things:
- Make sure to follow convention: We should adhere to Google convention.
- Comments should be consistent. Preferrably
//
Comment on lines
+7
to
+10
| oneof io_descriptor{ | ||
| string text = 1; | ||
| Array array = 2; | ||
| } |
There was a problem hiding this comment.
https://developers.google.com/protocol-buffers/docs/proto3#reserved
add a reserved message field for BentoService? @ssheng @sauyon ?
There was a problem hiding this comment.
We should reserve a range eventually, yes.
aarnphm
reviewed
Jul 13, 2022
aarnphm
reviewed
Jul 13, 2022
aarnphm
reviewed
Jul 13, 2022
aarnphm
reviewed
Jul 13, 2022
aarnphm
reviewed
Jul 13, 2022
aarnphm
approved these changes
Jul 13, 2022
aarnphm
added a commit
that referenced
this pull request
Jul 14, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 17, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 19, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 19, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 21, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 24, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Jul 30, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 3, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Aug 8, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: Sadab Hafiz <sadabhafizny@gmail.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
The generic proto file contains a
BentoMLservice with an RPC calledcall. Fixedio_descriptor.protofile with updated name ofArrayinstead ofNumpyNdarray.Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
The proto file and changes are based on our discussion. Would appreciate any feedback!
@aarnphm @sauyon @ssheng