fix: remove chmod install scripts #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
+ Coverage 70.08% 70.25% +0.16%
==========================================
Files 130 116 -14
Lines 10153 10190 +37
==========================================
+ Hits 7116 7159 +43
+ Misses 3037 3031 -6
|
sauyon
reviewed
Jul 28, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
previously approved these changes
Jul 29, 2022
parano
reviewed
Jul 29, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
commented
Jul 29, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
|
cc @sauyon |
aarnphm
commented
Aug 6, 2022
sauyon
reviewed
Aug 8, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
reviewed
Aug 9, 2022
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
parano
reviewed
Aug 9, 2022
| @@ -225,6 +226,13 @@ def write_to_bento( | |||
| setup_script = resolve_user_filepath(self.setup_script, build_ctx) | |||
| except FileNotFoundError as e: | |||
| raise InvalidArgument(f"Invalid setup_script file: {e}") | |||
| if not os.access(setup_script, os.X_OK): | |||
There was a problem hiding this comment.
The chmod in the dockerfile are just docker related, we want to have a executable check here so that users make sure the script is runnable.
There was a problem hiding this comment.
@aarnphm it's not necessary, right? since we only run that script in docker?
There was a problem hiding this comment.
I think the intention for this is to check whether a script is executable or not. But that evolve using a library like python-magic. I think we end up just doing this as a first pass.
There was a problem hiding this comment.
I'm not entirely sure what we want to do here. But the check is indeed not required.
There was a problem hiding this comment.
🤔 We can remove this if this means less friction for user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com
What does this PR address?
install.shand all related scripts generated by BentoML should use bash to runinstead of
chmod +x.Usually
chmod +xare not recommended for container application.Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
cc @sauyon