feat: use yatai proxy to upload/download bentos/models #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 70.93% 70.69% -0.25%
==========================================
Files 103 103
Lines 9334 9380 +46
==========================================
+ Hits 6621 6631 +10
- Misses 2713 2749 +36
|
|
@yetone Do we want to make s3 presigned URL an option for user to enable? we may need that for backwards compatible as well |
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
2 times, most recently
from
0e2b8b4
to
a83684b
Compare
|
Hello @yetone, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2022-08-17 10:35:57 UTC |
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
2 times, most recently
from
bd634ee
to
a6dec06
Compare
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
2 times, most recently
from
f7c55ab
to
974b812
Compare
yetone
changed the title
|
@parano Forward compatibility is complete, please review and merge |
yetone
commented
Aug 12, 2022
| cpu=r.resource_config.cpu, | ||
| nvidia_gpu=r.resource_config.nvidia_gpu, | ||
| custom_resources=r.resource_config.custom_resources, | ||
| cpu=r.resource_config.get("cpu"), |
There was a problem hiding this comment.
I hope this type-level refactoring needs to be synchronized to all the places where the type is used, and it feels like we need to add all the type checks to our ci, otherwise, it's a nullity
aarnphm
reviewed
Aug 12, 2022
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
from
974b812
to
301a64c
Compare
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
2 times, most recently
from
376b627
to
183dc75
Compare
yetone
force-pushed
the
feat/use-yatai-artifacts-proxy
branch
from
183dc75
to
f95765c
Compare
bojiang
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.