fix(configuration): merging global runner config to runner specific config #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jjmachan, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2022-08-02 11:19:14 UTC |
Codecov Report
@@ Coverage Diff @@
## main #2849 +/- ##
==========================================
+ Coverage 70.02% 70.12% +0.09%
==========================================
Files 114 114
Lines 9811 9806 -5
==========================================
+ Hits 6870 6876 +6
+ Misses 2941 2930 -11
|
jjmachan
requested review from
ssheng and
sauyon
and removed request for
a team
aarnphm
pushed a commit
that referenced
this pull request
Aug 3, 2022
…onfig (#2849) * merge global and runner specific instructions * tests * fix pep8 * remove breakpoing * flush * more asserts * close file to work in windows Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.