-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grpc): readthedocs build #2866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
force-pushed
the
style/docs-styling
branch
from
August 5, 2022 07:35
89ed507
to
c6a1249
Compare
aarnphm
force-pushed
the
style/docs-styling
branch
from
August 5, 2022 07:39
c6a1249
to
127485c
Compare
fix: add mypy-protobuf to docs build Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
style/docs-styling
branch
from
August 5, 2022 07:59
127485c
to
f9ebb69
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
style/docs-styling
branch
from
August 5, 2022 10:52
3fdb0c4
to
061c314
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Hello @aarnphm, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2022-08-05 11:34:44 UTC |
Codecov Report
@@ Coverage Diff @@
## grpc #2866 +/- ##
==========================================
- Coverage 67.19% 65.35% -1.84%
==========================================
Files 121 126 +5
Lines 10044 10631 +587
==========================================
+ Hits 6749 6948 +199
- Misses 3295 3683 +388
|
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 5, 2022
aarnphm
added a commit
to aarnphm/BentoML
that referenced
this pull request
Aug 8, 2022
aarnphm
added a commit
that referenced
this pull request
Aug 9, 2022
aarnphm
added a commit
that referenced
this pull request
Aug 9, 2022
aarnphm
added a commit
that referenced
this pull request
Aug 14, 2022
aarnphm
added a commit
that referenced
this pull request
Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
added a commit
that referenced
this pull request
Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.