Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): readthedocs build #2866

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 5, 2022

What does this PR address?

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Before submitting:

@aarnphm aarnphm requested a review from a team as a code owner August 5, 2022 07:31
@aarnphm aarnphm requested review from larme and removed request for a team August 5, 2022 07:31
@aarnphm aarnphm changed the title fix: readthedocs build fix(grpc): readthedocs build Aug 5, 2022
fix: add mypy-protobuf to docs build

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented Aug 5, 2022

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2022-08-05 11:34:44 UTC

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #2866 (25a8f45) into grpc (c32c350) will decrease coverage by 1.83%.
The diff coverage is 54.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##             grpc    #2866      +/-   ##
==========================================
- Coverage   67.19%   65.35%   -1.84%     
==========================================
  Files         121      126       +5     
  Lines       10044    10631     +587     
==========================================
+ Hits         6749     6948     +199     
- Misses       3295     3683     +388     
Impacted Files Coverage Δ
bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (ø)
bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (ø)
bentoml/_internal/server/cli/grpc_api_server.py 0.00% <0.00%> (ø)
...entoml/_internal/server/cli/grpc_dev_api_server.py 0.00% <0.00%> (ø)
...entoml/_internal/server/cli/http_dev_api_server.py 0.00% <0.00%> (ø)
bentoml/_internal/server/grpc/__init__.py 0.00% <0.00%> (ø)
...oml/_internal/server/grpc/interceptors/__init__.py 0.00% <0.00%> (ø)
...internal/server/grpc/interceptors/opentelemetry.py 0.00% <0.00%> (ø)
...l/_internal/server/grpc/interceptors/prometheus.py 0.00% <0.00%> (ø)
bentoml/_internal/server/grpc/server.py 0.00% <0.00%> (ø)
... and 98 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 8b5fe25 into bentoml:grpc Aug 5, 2022
@aarnphm aarnphm deleted the style/docs-styling branch August 5, 2022 11:39
aarnphm added a commit that referenced this pull request Aug 5, 2022
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Aug 8, 2022
aarnphm added a commit that referenced this pull request Aug 9, 2022
aarnphm added a commit that referenced this pull request Aug 9, 2022
aarnphm added a commit that referenced this pull request Aug 14, 2022
aarnphm added a commit that referenced this pull request Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit that referenced this pull request Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit that referenced this pull request Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit that referenced this pull request Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants