Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(containerize): supports passing multiple tags #2872

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 6, 2022

What does this PR address?

-t should create multiple docker image tag. This PR address the current
behaviour where the only last tag will be omitted.

Before submitting:

@aarnphm aarnphm requested review from ssheng, parano and a team as code owners August 6, 2022 06:47
@aarnphm aarnphm requested review from sauyon and removed request for a team August 6, 2022 06:47
@pep8speaks
Copy link

pep8speaks commented Aug 6, 2022

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2022-08-09 05:38:38 UTC

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #2872 (8a2c97d) into main (86fd357) will increase coverage by 0.68%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   70.05%   70.74%   +0.68%     
==========================================
  Files         121      104      -17     
  Lines        9785     9334     -451     
==========================================
- Hits         6855     6603     -252     
+ Misses       2930     2731     -199     
Impacted Files Coverage Δ
bentoml/_internal/utils/docker.py 68.96% <60.00%> (-4.95%) ⬇️
bentoml/_internal/utils/buildx.py 48.99% <80.00%> (ø)
bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (-95.92%) ⬇️
bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (-72.64%) ⬇️
bentoml/_internal/runner/strategy.py 74.13% <0.00%> (-8.63%) ⬇️
bentoml/_internal/runner/runner_handle/local.py 76.00% <0.00%> (-8.00%) ⬇️
bentoml/_internal/models/model.py 88.07% <0.00%> (-1.76%) ⬇️
bentoml/_internal/runner/runner.py 90.90% <0.00%> (-0.91%) ⬇️
bentoml/__init__.py
bentoml/bentos.py
... and 15 more

@aarnphm aarnphm force-pushed the fix/containerize_multiple_tags branch from 88f80a6 to b8d6a41 Compare August 6, 2022 06:50
bentoml/_internal/utils/buildx.py Outdated Show resolved Hide resolved
bentoml/_internal/utils/docker.py Show resolved Hide resolved
aarnphm and others added 8 commits August 8, 2022 22:37
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm force-pushed the fix/containerize_multiple_tags branch from 34c91d0 to 8a2c97d Compare August 9, 2022 05:38
@aarnphm aarnphm changed the title fix: containerize should accept multiple tags fix(containerize): supports passing multiple tags Aug 11, 2022
@aarnphm aarnphm merged commit 7eab6ce into bentoml:main Aug 11, 2022
@aarnphm aarnphm deleted the fix/containerize_multiple_tags branch August 11, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants