Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: analytics unit tests #2878

Merged
merged 3 commits into from
Aug 10, 2022
Merged

qa: analytics unit tests #2878

merged 3 commits into from
Aug 10, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 8, 2022

What does this PR address?

Add some more unit test for metrics.

Before submitting:

@aarnphm aarnphm requested a review from a team as a code owner August 8, 2022 09:12
@aarnphm aarnphm requested review from parano and removed request for a team August 8, 2022 09:12
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2878 (2d69438) into main (fdbdc14) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2878      +/-   ##
==========================================
+ Coverage   70.70%   70.89%   +0.19%     
==========================================
  Files         103      103              
  Lines        9302     9319      +17     
==========================================
+ Hits         6577     6607      +30     
+ Misses       2725     2712      -13     
Impacted Files Coverage Δ
bentoml/_internal/utils/analytics/schemas.py 96.45% <100.00%> (ø)
bentoml/_internal/utils/analytics/usage_stats.py 96.42% <100.00%> (+18.81%) ⬆️
bentoml/_internal/runner/runnable.py 93.75% <0.00%> (+1.56%) ⬆️

@aarnphm aarnphm requested a review from ssheng August 8, 2022 09:18
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented Aug 10, 2022

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2022-08-10 07:44:58 UTC

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm changed the title test(qa): metrics qa: analytics unit tests Aug 10, 2022
@aarnphm aarnphm merged commit e88db35 into bentoml:main Aug 10, 2022
@aarnphm aarnphm deleted the tests/metrics branch August 10, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants