Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): click utilities imports #2883

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 9, 2022

refactor click utilities that is mainly used by entrypoints scripts to bentoml_cli
cc @jjmachan this should fix most of the problems now.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner August 9, 2022 11:21
@aarnphm aarnphm requested review from jjmachan and removed request for a team August 9, 2022 11:21
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #2883 (2ca3d25) into main (3ebf161) will increase coverage by 1.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
+ Coverage   69.50%   70.70%   +1.20%     
==========================================
  Files         104      103       -1     
  Lines        9332     9302      -30     
==========================================
+ Hits         6486     6577      +91     
+ Misses       2846     2725     -121     
Impacted Files Coverage Δ
bentoml/_internal/utils/__init__.py 77.25% <0.00%> (+0.47%) ⬆️
bentoml/_internal/runner/runner_handle/remote.py 88.17% <0.00%> (+3.22%) ⬆️
bentoml/_internal/utils/circus/__init__.py 90.00% <0.00%> (+30.00%) ⬆️
bentoml/_internal/utils/docker.py 73.91% <0.00%> (+34.78%) ⬆️
bentoml/_internal/utils/buildx.py 48.99% <0.00%> (+48.99%) ⬆️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm changed the title fix(e2e): missing click utilities imports fix(cli): click utilities imports Aug 9, 2022
@aarnphm aarnphm merged commit ce6342d into bentoml:main Aug 9, 2022
@aarnphm aarnphm deleted the fix/tests-e2e branch August 9, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant