fix(scheduling): raise an error for invalid resources #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojiang
added
the
pr/merge-hold
bojiang
force-pushed
the
fix-default-scheduler
branch
from
f7e44b5
to
0ce88b2
Compare
bojiang
removed
the
pr/merge-hold
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 70.85% 70.15% -0.70%
==========================================
Files 103 120 +17
Lines 9328 9785 +457
==========================================
+ Hits 6609 6865 +256
- Misses 2719 2920 +201
|
aarnphm
approved these changes
Aug 11, 2022
ssheng
approved these changes
Aug 12, 2022
|
There were CI test failures. Could you please take a look, @bojiang? |
aarnphm
changed the title
aarnphm
pushed a commit
that referenced
this pull request
Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.