-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add external_modules option to save_model #2895
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage 70.54% 70.54%
=======================================
Files 104 104
Lines 9497 9497
=======================================
Hits 6700 6700
Misses 2797 2797 |
@bojiang can you fetch main and run the test again? |
3ef41b8
to
3bc278d
Compare
rebased to the main |
d138141
to
7f380c3
Compare
@@ -78,5 +78,4 @@ USER bentoml | |||
|
|||
ENTRYPOINT [ "{{ bento__entrypoint }}" ] | |||
|
|||
CMD [ "bentoml", "serve", "{{ bento__path }}", "--production" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why Do we remove this? I guess we will handle this from the entrypoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both CMD and ENTRYPOINT exist, the CMD would be passed to ENTRYPOINT if no args provided
bentoml/serve.py
Outdated
from circus.sockets import CircusSocket # type: ignore | ||
from circus.watcher import Watcher # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from circus.sockets import CircusSocket # type: ignore | |
from circus.watcher import Watcher # type: ignore | |
from circus.sockets import CircusSocket | |
from circus.watcher import Watcher |
7f380c3
to
0e9d743
Compare
1708e3a
to
4b9b1ce
Compare
TODO:
for #2785