Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: ssl styling and default value check #2899

Merged
merged 4 commits into from
Aug 13, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 12, 2022

What does this PR address?

Fixes some styling from #2886

Before submitting:

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested review from ssheng, parano and a team as code owners August 12, 2022 11:46
@aarnphm aarnphm requested review from larme and removed request for a team August 12, 2022 11:46
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #2899 (8643d93) into main (a48d83e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2899   +/-   ##
=======================================
  Coverage   70.93%   70.93%           
=======================================
  Files         103      103           
  Lines        9334     9335    +1     
=======================================
+ Hits         6621     6622    +1     
  Misses       2713     2713           
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 80.81% <100.00%> (+0.11%) ⬆️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
Copy link
Member Author

aarnphm commented Aug 13, 2022

Unit test has been failing, will fix in different PR.

@aarnphm aarnphm merged commit 8ab809d into bentoml:main Aug 13, 2022
@aarnphm aarnphm deleted the patch/ssl branch August 13, 2022 00:44
aarnphm added a commit that referenced this pull request Aug 14, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant