Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codespace #2907

Merged
merged 8 commits into from
Aug 17, 2022
Merged

feat: codespace #2907

merged 8 commits into from
Aug 17, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 15, 2022

added codespace support

@aarnphm aarnphm requested a review from a team as a code owner August 15, 2022 06:50
@aarnphm aarnphm requested review from larme and yubozhao and removed request for a team August 15, 2022 06:50
@parano
Copy link
Member

parano commented Aug 15, 2022

@aarnphm how do you test this out?

@aarnphm aarnphm force-pushed the feat/codespace branch 3 times, most recently from 4c74f5d to dddbcd4 Compare August 15, 2022 18:51
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #2907 (54f9f2a) into main (f9997c5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 54f9f2a differs from pull request most recent head 811a7f0. Consider uploading reports for the commit 811a7f0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   70.93%   70.92%   -0.01%     
==========================================
  Files         103      103              
  Lines        9334     9369      +35     
==========================================
+ Hits         6621     6645      +24     
- Misses       2713     2724      +11     
Impacted Files Coverage Δ
bentoml/_internal/utils/analytics/schemas.py 93.71% <100.00%> (-2.74%) ⬇️
bentoml/_internal/utils/uri.py 84.21% <0.00%> (-5.27%) ⬇️
bentoml/_internal/resource.py 74.54% <0.00%> (-2.43%) ⬇️
bentoml/_internal/runner/strategy.py 84.48% <0.00%> (+0.27%) ⬆️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
fix plugins installation and manage lifecycle for plugins

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm force-pushed the feat/codespace branch 5 times, most recently from 265ff88 to e4e1052 Compare August 15, 2022 22:49
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from ssheng August 17, 2022 06:32
@yubozhao
Copy link
Contributor

LGTM

@aarnphm aarnphm merged commit 2a12ce9 into bentoml:main Aug 17, 2022
@aarnphm aarnphm deleted the feat/codespace branch August 17, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants