fix(json): revert eager check #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
yubozhao
previously approved these changes
Aug 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
- Coverage 70.82% 70.70% -0.12%
==========================================
Files 104 104
Lines 9435 9442 +7
==========================================
- Hits 6682 6676 -6
- Misses 2753 2766 +13
|
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
yubozhao
previously approved these changes
Aug 19, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
fix/remove-pydantic
branch
from
acea23b
to
741a86f
Compare
parano
reviewed
Aug 22, 2022
| import pydantic | ||
|
|
||
| # This is to prevent cases where custom JSON encoder is used. | ||
| if isinstance(obj, pydantic.BaseModel): |
There was a problem hiding this comment.
This is not correct right? checking object instance is independent of whether self._pydantic_model is set or not.
validate should be raised from error Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
commented
Aug 22, 2022
sauyon
approved these changes
Aug 25, 2022
| @@ -241,14 +241,16 @@ async def from_http_request(self, request: Request) -> JSONType: | |||
| pydantic_model = self._pydantic_model.parse_obj(json_obj) | |||
| return pydantic_model | |||
| except pydantic.ValidationError as e: | |||
| raise BadInput(f"Invalid JSON input received: {e}") from None | |||
| raise BadInput(f"Invalid JSON input received: {e}") from e | |||
There was a problem hiding this comment.
Hm, do you know why this was None before?
There was a problem hiding this comment.
@sauyon @aarnphm https://peps.python.org/pep-0415/ that was for better exception context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an eager check for a pydantic object.
Our JSONEncoder should already handle pydantic object lazily
https://bentoml.slack.com/archives/CKRANBHPH/p1660930201114169