chore: Lock OpenTelemetry versions and add tracing metadata #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ssheng, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2022-08-22 08:35:54 UTC |
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 69.80% 69.86% +0.05%
==========================================
Files 121 121
Lines 9930 9954 +24
==========================================
+ Hits 6932 6954 +22
- Misses 2998 3000 +2
|
aarnphm
reviewed
Aug 21, 2022
bentoml/_internal/log.py
Outdated
Comment on lines
100
to
104
| result: str = ( | ||
| component_context.component_type | ||
| if component_context.component_type is not None | ||
| else "" | ||
| ) |
There was a problem hiding this comment.
imo separating these into two lines are better for better clearance.
There was a problem hiding this comment.
I'm not exactly sure if I understood the suggestion. Would you like to add a suggestion and I will commit.
aarnphm
reviewed
Aug 22, 2022
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
approved these changes
Aug 22, 2022
|
@ssheng I'm late to the party but it looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Following #2918, verified that the latest OpenTelemetry version
0.33b0is compatible with the existingotlp,jaegerandzipkinexporters. Locking the dependency versions until OTEL stabilizes.In addition, this PR also configures the OpenTelemetry resource automatically if user has not explicitly configured it through environment variables.
Individual trace page on Jaeger. API server and runners are labeled as separate services.
Search page:
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.