fix: use a temporary file for file uploads #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should alleviate some of the performance issues observed due to the current implementation of formparser: using a Python list for large data (greater than megabytes) appears to have a severely detrimental (effects measured in minutes) effect on performance.
Codecov Report
@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 70.79% 70.62% -0.17%
==========================================
Files 104 104
Lines 9470 9496 +26
==========================================
+ Hits 6704 6707 +3
- Misses 2766 2789 +23
|
ssheng
reviewed
Aug 25, 2022
ssheng
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should alleviate some of the performance issues observed due to the current implementation of formparser: using a Python list for large data (greater than megabytes) appears to have a severely detrimental (effects measured in minutes) effect on performance.