fix: importing mlflow:/ urls with no extra path info #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssheng
approved these changes
Aug 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
+ Coverage 69.80% 70.71% +0.90%
==========================================
Files 121 104 -17
Lines 9930 9446 -484
==========================================
- Hits 6932 6680 -252
+ Misses 2998 2766 -232
|
ssheng
reviewed
Aug 23, 2022
Comment on lines
+215
to
+216
| if os.path.isdir(download_dir): | ||
| shutil.rmtree(download_dir) |
There was a problem hiding this comment.
I'd suggest to put this logic in a finally block. We can merge this and add the finally block as a follow-up.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
When importing a MLFlow model with a models:/ URI, the downloader puts the files at the registered model path directly into the
dst_path. Whendst_pathis specified asbento_model.pathin this case, the downloader simply returns that same value. Ifbentoml_model.pathhad the value/tmp/test_tmp_path, then the subsequent rename of the downloaded dir tomlflow_modelto turn into the equivalent of:shutil.move(/tmp/test_tmp_path, /tmp/test_tmp_path/mlflow_model), which is going to always fail. The other URI types I've tried don't seem to do this, they all seem to create a subdirectory underbento_model.pathas a side effect of the download.This fix creates an extra directory to download into, so if a
models:/URI is used, it will instead download into this directory and give theshutil.movesomething to rename. If the directory is still there after the fact, it's cleaned up.Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.