Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove multipart IO descriptor warning #2936

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

ssheng
Copy link
Collaborator

@ssheng ssheng commented Aug 25, 2022

What does this PR address?

Using the multi-part IO descriptor shouldn't be resulting in a warning. 馃槉

Before submitting:

Who can help review?

Feel free to tag members/contributors who can help review your PR.

@ssheng ssheng requested a review from a team as a code owner August 25, 2022 00:57
@ssheng ssheng requested review from aarnphm and removed request for a team August 25, 2022 00:57
@ssheng ssheng changed the title chore: Update batching docs chore: remove multipart IO descriptor warning Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #2936 (07a07b7) into main (e02fa41) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
- Coverage   70.75%   70.48%   -0.27%     
==========================================
  Files         104      104              
  Lines        9466     9505      +39     
==========================================
+ Hits         6698     6700       +2     
- Misses       2768     2805      +37     
Impacted Files Coverage 螖
bentoml/_internal/service/service.py 96.70% <酶> (-0.11%) 猬囷笍
bentoml/_internal/frameworks/mlflow.py 57.54% <0.00%> (-33.50%) 猬囷笍
bentoml/_internal/configuration/containers.py 78.50% <0.00%> (酶)
bentoml/_internal/yatai_rest_api_client/schemas.py 93.53% <0.00%> (酶)
bentoml/_internal/runner/runner_handle/remote.py 88.54% <0.00%> (+0.36%) 猬嗭笍
bentoml/_internal/log.py 85.96% <0.00%> (+3.50%) 猬嗭笍

@sauyon
Copy link
Contributor

sauyon commented Aug 25, 2022

I feel like this warning should probably exist somewhere, though maybe not everywhere this is used.

@ssheng
Copy link
Collaborator Author

ssheng commented Aug 25, 2022

I feel like this warning should probably exist somewhere, though maybe not everywhere this is used.

I'm thinking the warning is not very actionable and advise against something we support.

@sauyon
Copy link
Contributor

sauyon commented Aug 25, 2022

I think in the majority of cases users probably want to be using JSON output or similar and not multipart.

We should probably have some sort of support for JSONifying multiple IO descriptor outputs; having our default output be a multipart response is very strange in my opinion.

@aarnphm aarnphm merged commit f6f24fc into bentoml:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants