Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --config flag to load the bentoml runtime config #2939

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented Aug 25, 2022

What does this PR address?

We used a --config flag in our bentoml cli to load the bentoml config. However, the recommended way to load the config is by setting the env var BENTOML_CONFIG to the config file's path. This PR will remove the --config flag from bentoml_cli

Before submitting:

Who can help review?

Feel free to tag members/contributors who can help review your PR.

@jjmachan jjmachan requested a review from a team as a code owner August 25, 2022 16:34
@jjmachan jjmachan requested review from bojiang and removed request for a team August 25, 2022 16:34
@jjmachan jjmachan added this to the 1.0.4 milestone Aug 25, 2022
@sauyon
Copy link
Contributor

sauyon commented Aug 25, 2022

Wait, why are we doing this? This seems like a backwards-incompatible change.

@ssheng
Copy link
Collaborator

ssheng commented Aug 25, 2022

Wait, why are we doing this? This seems like a backwards-incompatible change.

Discussed with Sauyon offline.

@ssheng ssheng merged commit 1efcca6 into bentoml:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants