Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): docker message #3012

Merged
merged 1 commit into from Sep 19, 2022
Merged

fix(grpc): docker message #3012

merged 1 commit into from Sep 19, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Sep 18, 2022

This PR fixes message output after successfully built Docker image where tags are None

@aarnphm aarnphm requested a review from a team as a code owner September 18, 2022 02:41
@aarnphm aarnphm requested review from ssheng and removed request for a team September 18, 2022 02:41
This was referenced Sep 18, 2022
@aarnphm aarnphm force-pushed the fix/docker-message branch 5 times, most recently from 734c6e6 to ce5f6c9 Compare September 18, 2022 08:34
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
from click import Group

from bentoml._internal.bento import BentoStore

F = t.Callable[..., t.Any]
Copy link
Member

@bojiang bojiang Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not, but I will remove it in a separate PR.

@aarnphm aarnphm changed the title fix: docker message fix(grpc): docker message Sep 19, 2022
@aarnphm aarnphm merged commit e02218d into bentoml:main Sep 19, 2022
@aarnphm aarnphm deleted the fix/docker-message branch September 19, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants