New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configuration): override options with envvar #3018
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
- Coverage 62.89% 60.98% -1.92%
==========================================
Files 145 132 -13
Lines 11828 11538 -290
Branches 0 1913 +1913
==========================================
- Hits 7439 7036 -403
+ Misses 4389 4133 -256
- Partials 0 369 +369
|
3fbbf51
to
7516ea2
Compare
I'm thinking to pass it as a bentoml serve --production --config-options 'runners.pytorch_mnist.resources."nvidia.com/gpu"=[0,2]' --config-options "api_server.http.metrics.enabled=false" |
7516ea2
to
389eb96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will write some tests for this is the test PR I have 😄
update some types annotations Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did some manual QA for this feature. Works like a charm 😄
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Some use cases:
1. override one value
assign a gpu for a runner
equal to
2. override multiple values (divide with space or new line)
assign two specified gpus to a runner
or
equal to
or