Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates on blocks that failed to render #3031

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Sep 21, 2022

There are some docs block that are not render

also start migrating :code: to double backtick for inline

@aarnphm aarnphm requested a review from a team as a code owner September 21, 2022 21:39
@aarnphm aarnphm requested review from larme and removed request for a team September 21, 2022 21:39
@aarnphm aarnphm changed the title chore: updates on blocks that failed to render docs: updates on blocks that failed to render Sep 21, 2022
@larme
Copy link
Member

larme commented Sep 23, 2022

@aarnphm do we have a guideline for when to use :code: and when to use double backquotes? From the changes of this pr, are we going to stick with double backquotes?

@aarnphm
Copy link
Member Author

aarnphm commented Sep 23, 2022

I think it is a syntactic choice. double backtick feels more natural to markdown for inline.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aarnphm aarnphm merged commit 945189d into bentoml:main Sep 26, 2022
@aarnphm aarnphm deleted the docs/bento-format branch September 26, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants