fix(io): Pandas OpenAPI schema #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fix: PandasDataFrame orient does not change open api schema generation to expected format. Bug Fix: PandasSeries orient does not change open api schema generation to expected format. Separated openapi schema generation for each. PandasSeries from_http_request() seem to be missing io.BytesIO. Added it.
sauyon
previously approved these changes
Sep 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #3032 +/- ##
==========================================
- Coverage 62.82% 53.55% -9.28%
==========================================
Files 145 109 -36
Lines 11831 10655 -1176
==========================================
- Hits 7433 5706 -1727
- Misses 4398 4949 +551
|
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
aarnphm
previously approved these changes
Sep 22, 2022
|
Can you run |
|
Yes! Ran |
aarnphm
approved these changes
Sep 23, 2022
aarnphm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: PandasDataFrame orient does not change open api schema generation to expected format.
Bug Fix: PandasSeries orient does not change open api schema generation to expected format.
Separated openapi schema generation for each.
PandasSeries from_http_request() seem to be missing io.BytesIO. Added it.
What does this PR address?
When specifying the pandas PandasDataFrame and PandasSeries input spec the generated open api schemas do not match the expected schema with the provided orient parameter. This shows in the bento serve index webpage in the request body and successful response output sections. This PR seeks to address this by adding orient to the schema generation in addition to the existing the dtype dict parameter (Dataframe) or dtype str parameter (Series) to return the correct Schema.
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.