Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IO OpenAPI spec for bentoml.client #3144

Merged
merged 4 commits into from Oct 26, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Oct 26, 2022

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner October 26, 2022 04:08
@aarnphm aarnphm requested review from jjmachan and removed request for a team October 26, 2022 04:08
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3144 (fe92426) into main (e987397) will decrease coverage by 0.06%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   21.83%   21.76%   -0.07%     
==========================================
  Files          98      100       +2     
  Lines        9356     9610     +254     
  Branches     1611     1663      +52     
==========================================
+ Hits         2043     2092      +49     
- Misses       7266     7470     +204     
- Partials       47       48       +1     
Impacted Files Coverage Δ
...c/bentoml/_internal/bento/build_dev_bentoml_whl.py 28.94% <ø> (-1.83%) ⬇️
src/bentoml/_internal/io_descriptors/multipart.py 44.57% <ø> (ø)
src/bentoml/_internal/io_descriptors/pandas.py 32.08% <13.63%> (-2.74%) ⬇️
src/bentoml/_internal/io_descriptors/image.py 30.32% <50.00%> (-0.89%) ⬇️
src/bentoml/_internal/io_descriptors/base.py 82.35% <100.00%> (ø)
src/bentoml/_internal/io_descriptors/file.py 38.31% <100.00%> (-0.58%) ⬇️
src/bentoml/_internal/io_descriptors/json.py 33.09% <100.00%> (-0.48%) ⬇️
src/bentoml/_internal/io_descriptors/numpy.py 32.08% <100.00%> (-0.72%) ⬇️
src/bentoml/_internal/io_descriptors/text.py 58.82% <100.00%> (-1.56%) ⬇️
src/bentoml/_internal/marshal/dispatcher.py 0.00% <0.00%> (ø)
... and 3 more

aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 26, 2022
depends on bentoml#3144 to be merged.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 335f1c9 into bentoml:main Oct 26, 2022
@aarnphm aarnphm deleted the fix/client branch October 26, 2022 23:29
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Nov 7, 2022
depends on bentoml#3144 to be merged.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
ssheng pushed a commit that referenced this pull request Nov 9, 2022
* feat: from_sample impl

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* feat: from_sample

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: sample shouldn't be a memoryview [skip ci]

depends on #3144 to be merged.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* chore: move from_sample deps to optional via io-file

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* chore: dispatch by types for sample

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* feat: openapi and dispatcher fix

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* chore: refactor and __slots__ implementation for Base

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: types

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: tests [skip ci]

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: not using singledispatch

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: tests (incremental)

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* fix: different output

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* chore: update _from_sample implementation

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants