Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the BentoCloud Build doc #4104

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

Sherlock113
Copy link
Contributor

What does this PR address?

Update the BentoCloud Build doc. The example in the original doc does not work and is not appropriate for our audience. Replace it with a simple example.

Fixes #(issue)

Before submitting:

Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
@Sherlock113 Sherlock113 added documentation Documentation, tutorials, and example projects pr/merge-hold Requires further discussions before a pull request can be merged labels Aug 9, 2023
@Sherlock113 Sherlock113 requested a review from a team as a code owner August 9, 2023 09:23
@Sherlock113 Sherlock113 requested review from frostming and parano and removed request for a team and frostming August 9, 2023 09:23
@Sherlock113 Sherlock113 self-assigned this Aug 9, 2023
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
@Sherlock113
Copy link
Contributor Author

Wait until this repo https://github.com/bentoml/quickstart becomes public.

@Sherlock113 Sherlock113 removed the pr/merge-hold Requires further discussions before a pull request can be merged label Aug 9, 2023
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @parano

@parano parano merged commit 4065c9b into bentoml:main Aug 9, 2023
3 checks passed
@Sherlock113 Sherlock113 deleted the builddocs branch August 10, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, tutorials, and example projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants