chore(annotations): cleanup compat and fix ModelSignatureDict type #4162

aarnphm · 2023-08-31T23:24:53Z

What does this PR address?

Fixes #(issue)

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

jianshen92

Lgtm

aarnphm added 2 commits August 31, 2023 19:19

fix(signature): correct annotations for ModelSignatureDict

d6818d2

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: cleanup smaller 3.8 compat

5287853

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

aarnphm requested a review from a team as a code owner August 31, 2023 23:24

aarnphm requested review from frostming and removed request for a team August 31, 2023 23:24

jianshen92 self-requested a review September 1, 2023 10:24

jianshen92 approved these changes Sep 1, 2023

View reviewed changes

aarnphm merged commit d642016 into main Sep 1, 2023
41 of 45 checks passed

aarnphm deleted the fix/annotations branch September 1, 2023 15:50

sauyon approved these changes Sep 2, 2023

View reviewed changes