Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image encoding issue when the format is not specified #4435

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner January 20, 2024 13:57
@frostming frostming requested review from parano and removed request for a team January 20, 2024 13:57
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larme larme merged commit 2d73651 into 1.2 Jan 20, 2024
36 of 39 checks passed
@larme larme deleted the fix/image-encode branch January 20, 2024 14:02
frostming added a commit that referenced this pull request Feb 1, 2024
fix: give a default format when it's not specified

Signed-off-by: Frost Ming <me@frostming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants