Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock dependencies by default considering the current bentoml version #4484

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

…rsion

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner February 4, 2024 10:42
@frostming frostming requested review from aarnphm and bojiang and removed request for a team February 4, 2024 10:42
@bojiang
Copy link
Member

bojiang commented Feb 4, 2024

It still success even lock failed

Signed-off-by: Frost Ming <me@frostming.com>
@bojiang
Copy link
Member

bojiang commented Feb 4, 2024

✗ bentoml build
Locking PyPI package versions.
  ERROR: Cannot install bentoml==1.1.11 and bentoml==1.2.0 because these package versions have conflicting dependencies.
Traceback (most recent call last):
  File "/home/agent/.conda/envs/py3.11/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 397, in resolve
    self._add_to_criteria(self.state.criteria, r, parent=None)
  File "/home/agent/.conda/envs/py3.11/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 174, in _add_to_criteria
    raise RequirementsConflicted(criterion)
pip._vendor.resolvelib.resolvers.RequirementsConflicted: Requirements conflict: SpecifierRequirement('bentoml==1.2.0'), SpecifierRequirement('bentoml==1.1.11')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/agent/.conda/envs/py3.11/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 92, in resolve
    result = self._result = resolver.resolve(
                            ^^^^^^^^^^^^^^^^^
  File "/home/agent/.conda/envs/py3.11/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 546, in resolve
    state = resolution.resolve(requirements, max_rounds=max_rounds)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/agent/.conda/envs/py3.11/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 399, in resolve
    raise ResolutionImpossible(e.criterion.information)
pip._vendor.resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=SpecifierRequirement('bentoml==1.2.0'), parent=None), RequirementInformation(requirement=SpecifierRequirement('bentoml==1.1.11'), parent=None)]

The above exception was the direct cause of the following exception:

Need to notify our user we are adding current bentoml to python packages @frostming

@bojiang bojiang merged commit 5ca2085 into bentoml:main Feb 4, 2024
34 of 39 checks passed
@frostming frostming deleted the feat/lock-deps branch February 4, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants