Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): make CLI commands available as modules #4487

Merged
merged 4 commits into from Feb 23, 2024
Merged

refactor(cli): make CLI commands available as modules #4487

merged 4 commits into from Feb 23, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming frostming requested a review from a team as a code owner February 5, 2024 07:37
@frostming frostming requested review from sauyon and removed request for a team February 5, 2024 07:37
@frostming frostming changed the title feat(cli): make CLI commands avaiable as modules refactor(cli): make CLI commands avaiable as modules Feb 5, 2024
@frostming frostming changed the title refactor(cli): make CLI commands avaiable as modules refactor(cli): make CLI commands available as modules Feb 5, 2024
aarnphm
aarnphm reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if this affect openllm, since openllm is currently building on top of BentoMLCommandGroup.

@Sherlock113
Copy link
Contributor

@frostming Could you please solve the conflicts in this pull request? Thanks.
@aarnphm Let me know if you think merging this pull request will affect OpenLLM or you need to do some changes before this pull request can be merged. Thanks.

@aarnphm
Copy link
Member

aarnphm commented Feb 19, 2024 •
edited

This doesn't break openllm 0.4

Considering I'm rewriting openllm cli anw.

@frostming
feat(cli): make CLI commands avaiable as modules
11d13c9 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming
fix: handle bentoml group
bd723d1 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming
fix: simply aliases
5b3113a 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming
fix: rename bento_command
ad53333 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming enabled auto-merge (squash) February 23, 2024 09:09
@frostming frostming merged commit 7b0b0e6 into bentoml:main Feb 23, 2024
42 checks passed
@frostming frostming deleted the feat/cli-module branch February 23, 2024 09:41
@aarnphm aarnphm mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm left review comments

@Sherlock113 Sherlock113 Sherlock113 approved these changes

@sauyon sauyon Awaiting requested review from sauyon sauyon is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frostming @Sherlock113 @aarnphm