Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the clients doc #4539

Merged
merged 1 commit into from Mar 1, 2024
Merged

Conversation

Sherlock113
Copy link
Contributor

@Sherlock113 Sherlock113 commented Feb 28, 2024

What does this PR address?

  1. Added the error handling section.
  2. Updated code examples to not use the context manager.
  3. Added some Service code for better understanding of client code.

Before submitting:

Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
@Sherlock113 Sherlock113 requested a review from a team as a code owner February 28, 2024 13:04
@Sherlock113 Sherlock113 requested review from bojiang and removed request for a team February 28, 2024 13:04
@Sherlock113 Sherlock113 self-assigned this Feb 28, 2024
@Sherlock113 Sherlock113 added the documentation Documentation, tutorials, and example projects label Feb 28, 2024
Copy link
Contributor

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sherlock113 Sherlock113 merged commit bc76ffa into bentoml:main Mar 1, 2024
4 checks passed
@Sherlock113 Sherlock113 deleted the adjustclientdoc branch March 1, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, tutorials, and example projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants