Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use jinja template for install script #4607

Merged
merged 4 commits into from Mar 26, 2024

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Mar 22, 2024

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

What does this PR address?

migrate install script to be in jinja for easier management

Fixes #(issue)

Before submitting:

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner March 22, 2024 05:19
@aarnphm aarnphm requested review from sauyon and frostming and removed request for a team March 22, 2024 05:19
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm
Copy link
Member Author

aarnphm commented Mar 26, 2024

@frostming should be good for another round of review here

Copy link
Contributor

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a minor concern that I suspect [[ ]] is more common in shell than {{ }}.

@aarnphm
Copy link
Member Author

aarnphm commented Mar 26, 2024

Mostly LGTM, just a minor concern that I suspect [[ ]] is more common in shell than {{ }}.

Ah you are right, how about << and >>?

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 058d28d into main Mar 26, 2024
39 of 41 checks passed
@aarnphm aarnphm deleted the chore/update-script-to-jinja branch March 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants