feat: cli auto login #4817
Merged
feat: cli auto login #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianml
force-pushed
the
feat/login-revamp
branch
from
3af06c0
to
db95e8c
Compare
|
Consider using |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Just need a one-time process server here. Would it be too heavy to start a starlette app? |
|
frostming
reviewed
Jun 19, 2024
frostming
reviewed
Jun 19, 2024
Makes sense, let's keep it |
xianml
force-pushed
the
feat/login-revamp
branch
2 times, most recently
from
0e826ef
to
f8d5cf4
Compare
frostming
reviewed
Jun 20, 2024
frostming
reviewed
Jun 20, 2024
xianml
force-pushed
the
feat/login-revamp
branch
from
2ffaa21
to
80ef5d7
Compare
frostming
approved these changes
Jun 25, 2024
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
xianml
force-pushed
the
feat/login-revamp
branch
from
6975510
to
d867b9e
Compare
For more information, see https://pre-commit.ci
frostming
approved these changes
Jun 25, 2024
aarnphm
reviewed
Jun 25, 2024
| from starlette.testclient import TestClient | ||
| from typing_extensions import Annotated |
There was a problem hiding this comment.
doesn't seem like this change is related?
There was a problem hiding this comment.
No, but it's just an import reorder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
support cli auto login
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.