Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject prometheus multiproc_dir into env var when worker starts #4820

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner June 20, 2024 07:16
@frostming frostming requested review from larme and bojiang and removed request for a team June 20, 2024 07:16
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@aarnphm
Copy link
Member

aarnphm commented Jun 21, 2024

my only concern with this is that users might override this envvar, and it would break bentoml.

I think the reason we have bentoml.metrics is for separation of concern. If users want to use prometheus_client then it is on the users to do their metrics, whereas with bentoml.metrics it falls under bentoml

@frostming frostming merged commit 65e7176 into bentoml:main Jun 23, 2024
41 of 42 checks passed
@frostming frostming deleted the feat/multiproc-dir branch June 23, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants