Add fastai2_model_artifact

[HenryDashwood]

(Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below.)

What changes were proposed in this pull request?

Adds a fastai2_model_artifact

Does this close any currently open issues?

No

How was this patch tested?

[pep8speaks]

Hello @HenryDashwood, Thanks for updating this PR.

• In the file bentoml/artifact/fastai2_model_artifact.py:

Line 34:89: E501 line too long (90 > 88 characters)
Line 47:89: E501 line too long (89 > 88 characters)
Line 95:1: W293 blank line contains whitespace

• In the file bentoml/bundler/bundler.py:

Line 106:1: W293 blank line contains whitespace

Comment last updated at 2020-05-05 22:13:41 UTC

[codecov-io]

Codecov Report

Merging #596 into master will decrease coverage by 0.04%.
The diff coverage is 48.83%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   56.08%   56.04%   -0.05%     
==========================================
  Files          99      100       +1     
  Lines        7542     7585      +43     
==========================================
+ Hits         4230     4251      +21     
- Misses       3312     3334      +22     

Impacted Files	Coverage Δ
bentoml/bundler/bundler.py	93.75% <ø> (ø)
bentoml/service.py	89.87% <ø> (ø)
bentoml/artifact/fastai2_model_artifact.py	47.61% <47.61%> (ø)
bentoml/artifact/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacd9d7...8479245. Read the comment docs.

[parano]

@HenryDashwood thanks for updating the PR, I assume this is ready for review now? I will try it out on my end later today and update with you if I had any feedback.

[HenryDashwood]

Cheers! There's a slight difference for the user when saving the model as we have to use Sylvain's context manager:

with remove_patches_path():
    saved_path = service.save()

Would it be better if this were handled by Bentoml internally?

[parano]

@HenryDashwood I'm planning to make the following change in BentoML to avoid that issue with fastcore's patch:

Instead of doing yaml.dump(y, Path("/tmp/test.yml")), we will use:

with open('/tmp/test.yaml', 'wb') as fp:
    yaml.dump(y, fp)

I will create a PR for that soon and test it together with your PR. I think after that change, the user won't need to use the remove_patches_path any more.

[HenryDashwood]

Ah that's perfect then!