Add micro-batching support to ImageHandler #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bojiang, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2020-05-27 09:32:20 UTC |
bojiang
force-pushed
the
handler
branch
3 times, most recently
from
6c86252
to
0732698
Compare
bojiang
force-pushed
the
handler
branch
5 times, most recently
from
b6a5b65
to
cde08cc
Compare
bojiang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 53.84% 54.41% +0.57%
==========================================
Files 104 105 +1
Lines 8277 8385 +108
==========================================
+ Hits 4457 4563 +106
- Misses 3820 3822 +2
Continue to review full report at Codecov.
|
parano
reviewed
May 27, 2020
| return ['imageio'] | ||
| return ["imageio"] | ||
|
|
||
| def _load_image_data(self, request: Request): |
parano
reviewed
May 27, 2020
| @@ -19,6 +19,10 @@ ImageHandler | |||
| ++++++++++++ | |||
| .. autoclass:: bentoml.handlers.ImageHandler | |||
|
|
|||
| LegacyImageHandler | |||
parano
reviewed
May 27, 2020
|
|
||
|
|
||
| class LegacyImageHandler(BentoHandler): | ||
| """Transform incoming image data from http request, cli or lambda event into numpy |
There was a problem hiding this comment.
let's add a deprecation note here?
This LegacyImageHandler is identical to the ImageHandler prior to BentoML version 0.8.0, it was
kept here to make it easier for users to upgrade. If you are starting a new model serving project,
use the ImageHandler instead. LegacyImageHandler will be deprecated in release 1.0.0.
|
LGTM and merging now! There's one minor comment, feel free to address in future PRs since you are actively working on this code path. |
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* [Batching] implement batching for image_handler * Clean code & tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Components (if applicable)
Checklist:
./dev/format.shand./dev/lint.shscript have passed(instructions).