Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/TEST] Fix YataiService end-to-end tests #773

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

parano
Copy link
Member

@parano parano commented Jun 10, 2020

Description

  • Fixed dangling node process issue which causes running all tests in sequence to fail
  • Fixed test docker container not being terminated properly after each test run
  • chmod -x of a few legacy test script files
  • Removed the "bentoml run" call in the YataiService docker container test, since remote "LocalRepository" is not yet supported

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation
  • Test, CI, or build
  • None

Components (if applicable)

  • BentoService (model packaging, dependency management, handler definition)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, logging, metrics, tracing, benchmark, OpenAPI)
  • YataiService (model management, deployment automation)
  • Documentation

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change in bentoml/gallery example notebooks
  • I have sent a pull request to bentoml/gallery to make that change

@parano parano requested a review from yubozhao June 10, 2020 01:19
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is 68.03%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files         108      108           
  Lines        8158     8158           
=======================================
  Hits         4514     4514           
  Misses       3644     3644           
Impacted Files Coverage Δ
bentoml/yatai/deployment/operator.py 53.33% <0.00%> (ø)
bentoml/yatai/deployment/sagemaker/wsgi.py 0.00% <0.00%> (ø)
bentoml/yatai/repository/s3_repository.py 25.75% <25.75%> (ø)
bentoml/yatai/client/deployment_api.py 17.30% <33.33%> (ø)
bentoml/yatai/deployment/aws_lambda/operator.py 58.73% <58.73%> (ø)
bentoml/yatai/yatai_service_impl.py 33.83% <75.00%> (ø)
bentoml/yatai/repository/local_repository.py 75.75% <75.75%> (ø)
bentoml/yatai/deployment/sagemaker/operator.py 80.20% <80.20%> (ø)
bentoml/yatai/repository/repository.py 83.33% <83.33%> (ø)
bentoml/yatai/validator/deployment_pb_validator.py 95.00% <95.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4406531...de0c03d. Read the comment docs.

@parano parano merged commit b71b309 into bentoml:master Jun 10, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* fix

* refactor start_yatai_server to include "with modified_environ"

* e2e tests refactor

* fix dangling node process

* chmox -x

* fix e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant