Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpacyModelArtifact to bentoml.artifacts package #782

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

docteurZ
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation
  • Test, CI, or build
  • None

Components (if applicable)

  • BentoService (model packaging, dependency management, handler definition)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, logging, metrics, tracing, benchmark, OpenAPI)
  • YataiService (model management, deployment automation)
  • Documentation

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change in bentoml/gallery example notebooks
  • I have sent a pull request to bentoml/gallery to make that change

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #782 into master will increase coverage by 0.20%.
The diff coverage is 68.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   55.33%   55.53%   +0.20%     
==========================================
  Files         108      108              
  Lines        8158     8144      -14     
==========================================
+ Hits         4514     4523       +9     
+ Misses       3644     3621      -23     
Impacted Files Coverage Δ
bentoml/saved_bundle/config.py 94.56% <ø> (ø)
bentoml/yatai/deployment/operator.py 61.53% <0.00%> (+8.20%) ⬆️
bentoml/yatai/deployment/sagemaker/wsgi.py 0.00% <0.00%> (ø)
bentoml/yatai/deployment_utils.py 83.72% <ø> (+6.63%) ⬆️
bentoml/yatai/repository/s3_repository.py 25.75% <25.75%> (ø)
bentoml/yatai/client/deployment_api.py 17.30% <33.33%> (ø)
bentoml/yatai/deployment/aws_lambda/operator.py 58.73% <58.73%> (ø)
bentoml/yatai/yatai_service_impl.py 33.83% <75.00%> (ø)
bentoml/yatai/repository/local_repository.py 75.75% <75.75%> (ø)
bentoml/yatai/deployment/sagemaker/operator.py 80.20% <80.20%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea9848...3578259. Read the comment docs.

@parano
Copy link
Member

parano commented Jun 11, 2020

Thanks for fixing this @docteurZ

Just a quick note on a workaround for version 0.7.8 and older, user can still access SpacyModelArtifact via from bentoml.artifact.spacy_model_artifact import SpacyModelArtifact

@parano
Copy link
Member

parano commented Jun 11, 2020

Merging now!

@parano parano merged commit 2b47221 into bentoml:master Jun 11, 2020
@parano parano changed the title fix to actually use SpacyModelArtifact as a model Add SpacyModelArtifact to bentoml.artifacts package Jun 11, 2020
@docteurZ docteurZ deleted the fix-spacy branch June 11, 2020 11:52
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* fix to actually use SpacyModelArtifact as a model

* (linter) fix to actually use SpacyModelArtifact as a model

Co-authored-by: Hugo Zanghi <hugo.zanghi@linkfluence.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants