Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

test: removing old tests and fixing linting issues #117

Merged
merged 5 commits into from
Apr 18, 2022

Conversation

jjmachan
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoctl code style, both make format and
    make lint script have passed
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #117 (ba3b10b) into main (c117ff2) will decrease coverage by 24.64%.
The diff coverage is 21.22%.

@@             Coverage Diff             @@
##             main     #117       +/-   ##
===========================================
- Coverage   64.31%   39.67%   -24.65%     
===========================================
  Files          15       15               
  Lines         765      852       +87     
===========================================
- Hits          492      338      -154     
- Misses        273      514      +241     
Flag Coverage Δ
unit-tests 39.67% <21.22%> (-24.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/__init__.py 100.00% <ø> (ø)
bentoctl/cli/__init__.py 0.00% <0.00%> (-62.23%) ⬇️
bentoctl/cli/interactive.py 0.00% <0.00%> (-17.86%) ⬇️
bentoctl/cli/operator_management.py 0.00% <0.00%> (-43.86%) ⬇️
bentoctl/cli/utils.py 0.00% <0.00%> (-90.63%) ⬇️
bentoctl/docker_utils.py 0.00% <0.00%> (ø)
bentoctl/console.py 30.76% <18.18%> (-69.24%) ⬇️
bentoctl/utils.py 36.84% <35.13%> (+3.50%) ⬆️
bentoctl/deployment_config.py 62.87% <48.52%> (-17.52%) ⬇️
bentoctl/exceptions.py 80.32% <50.00%> (-7.43%) ⬇️
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jjmachan jjmachan merged commit d76e42b into bentoml:main Apr 18, 2022
@jjmachan jjmachan deleted the fix-ci branch April 18, 2022 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant