Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

test: adding tests #119

Merged
merged 15 commits into from
Apr 25, 2022
Merged

test: adding tests #119

merged 15 commits into from
Apr 25, 2022

Conversation

jjmachan
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoctl code style, both make format and
    make lint script have passed
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jjmachan jjmachan marked this pull request as draft April 19, 2022 18:44
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #119 (ed7fdcd) into main (67f51c5) will increase coverage by 34.97%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##             main     #119       +/-   ##
===========================================
+ Coverage   38.14%   73.12%   +34.97%     
===========================================
  Files          16       16               
  Lines         894      878       -16     
===========================================
+ Hits          341      642      +301     
+ Misses        553      236      -317     
Flag Coverage Δ
unit-tests 73.12% <91.66%> (+34.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/deployment_config.py 66.66% <ø> (+3.23%) ⬆️
bentoctl/cli/interactive.py 91.30% <80.00%> (+91.30%) ⬆️
bentoctl/cli/__init__.py 86.90% <100.00%> (+86.90%) ⬆️
bentoctl/docker_utils.py 20.00% <0.00%> (+20.00%) ⬆️
bentoctl/utils.py 73.68% <0.00%> (+36.84%) ⬆️
bentoctl/cli/operator_management.py 40.27% <0.00%> (+40.27%) ⬆️
bentoctl/cli/helper_scripts.py 45.00% <0.00%> (+45.00%) ⬆️
bentoctl/console.py 92.30% <0.00%> (+61.53%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jjmachan jjmachan marked this pull request as ready for review April 20, 2022 16:22
@yubozhao yubozhao requested a review from aarnphm April 21, 2022 02:34
@jjmachan
Copy link
Contributor Author

Merging this in. Looking forward to pairing up sometime @yubozhao and getting it to the 80+ coverage mark

@jjmachan jjmachan merged commit 4c40f11 into bentoml:main Apr 25, 2022
@jjmachan jjmachan deleted the more-tests branch April 25, 2022 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants