Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

feat: added a new destroy command and experimental apply command #123

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented Apr 20, 2022

Description

  • This adds a destroy command that will run terraform destroy and delete the created repository.
  • Also added an apply command that runs terraform apply for you.

Lambda Operator PR: bentoml/aws-lambda-deploy#36

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoctl code style, both make format and
    make lint script have passed
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #123 (8d774c8) into main (7a8119e) will decrease coverage by 1.57%.
The diff coverage is 12.24%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   39.71%   38.14%   -1.58%     
==========================================
  Files          15       16       +1     
  Lines         851      894      +43     
==========================================
+ Hits          338      341       +3     
- Misses        513      553      +40     
Flag Coverage Δ
unit-tests 38.14% <12.24%> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/cli/__init__.py 0.00% <0.00%> (ø)
bentoctl/cli/helper_scripts.py 0.00% <0.00%> (ø)
bentoctl/operator/operator.py 73.52% <50.00%> (-1.86%) ⬇️
bentoctl/deployment_config.py 63.43% <60.00%> (+0.55%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant