Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

fix: create_repository should returns repository_url instead of registry info #129

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

jjmachan
Copy link
Contributor

Description

Currently the create_repository return the url for registry but we want to use the repository url .

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoctl code style, both make format and
    make lint script have passed
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #129 (812076b) into main (91191ba) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          16       16           
  Lines         893      893           
=======================================
  Hits          645      645           
  Misses        248      248           
Flag Coverage Δ
unit-tests 72.22% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/deployment_config.py 66.66% <25.00%> (ø)
bentoctl/cli/__init__.py 86.90% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jjmachan
Copy link
Contributor Author

@yubozhao yubozhao merged commit 020535c into bentoml:main Apr 26, 2022
@jjmachan jjmachan deleted the fix branch May 16, 2022 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants