Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Operator version #134

Merged
merged 13 commits into from
May 11, 2022
Merged

Operator version #134

merged 13 commits into from
May 11, 2022

Conversation

yubozhao
Copy link
Contributor

@yubozhao yubozhao commented May 4, 2022

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the bentoctl code style, both make format and
    make lint script have passed
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@yubozhao yubozhao requested a review from jjmachan May 4, 2022 22:43
@yubozhao yubozhao mentioned this pull request May 5, 2022
@yubozhao yubozhao linked an issue May 5, 2022 that may be closed by this pull request
@jjmachan
Copy link
Contributor

jjmachan commented May 5, 2022

I guess we need to update the lock file too. You can run poetry lock --no-update so that it just updates the lock files without reinstalling bentoml

@yubozhao yubozhao marked this pull request as ready for review May 11, 2022 01:37
Copy link
Contributor

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we still have to update the tests. I can pitch in if you want to finish that up and may be can do a small refactor for the tests too

bentoctl/cli/operator_management.py Show resolved Hide resolved
bentoctl/operator/registry.py Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning for operators
2 participants