Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

refactor: bring common utils used accross the operators into one place #158

Merged
merged 6 commits into from
May 30, 2022

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented May 18, 2022

Description

This is to reduce duplication in the operators and I've moved some common utility functions from the operator into bentoctl.

The operators that use this approach

  1. google-compute-engine
  2. azure-container-instance
  3. heroku
    closes:

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #158 (26a83bf) into main (06547de) will decrease coverage by 4.98%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   65.37%   60.39%   -4.99%     
==========================================
  Files          19       24       +5     
  Lines        1031     1121      +90     
==========================================
+ Hits          674      677       +3     
- Misses        357      444      +87     
Flag Coverage Δ
unit-tests 60.39% <0.00%> (-4.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/utils/operator_helpers/__init__.py 0.00% <0.00%> (ø)
...ntoctl/utils/operator_helpers/create_deployable.py 0.00% <0.00%> (ø)
bentoctl/utils/operator_helpers/generate.py 0.00% <0.00%> (ø)
bentoctl/utils/operator_helpers/utils.py 0.00% <0.00%> (ø)
bentoctl/utils/operator_helpers/values.py 0.00% <0.00%> (ø)
bentoctl/exceptions.py 81.53% <0.00%> (+0.89%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jjmachan jjmachan marked this pull request as ready for review May 23, 2022 16:19
@jjmachan jjmachan requested a review from yubozhao May 23, 2022 16:22
@jjmachan jjmachan merged commit f49e0c7 into bentoml:main May 30, 2022
@jjmachan jjmachan deleted the operator-helpers branch May 30, 2022 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant