feat: add a debug mode for bentoctl #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 60.27% 59.80% -0.47%
==========================================
Files 24 24
Lines 1110 1117 +7
==========================================
- Hits 669 668 -1
- Misses 441 449 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -147,7 +146,6 @@ def build( | |||
| generate_deployable_container( | |||
| tag=local_docker_tag, | |||
| deployment_config=deployment_config, | |||
| cleanup=get_debug_mode(), | |||
There was a problem hiding this comment.
Shouldn't we clean up when not in debug mode? :)
| """ | ||
| Calls the operator and generates the deployable. If in debug more the generated | ||
| deployable will be moved to the current directory for easier debugging. | ||
| """ | ||
| with TempDirectory(debug=get_debug_mode()) as dist_dir: |
There was a problem hiding this comment.
Moving directory is a bit unnatural for debugging. Maybe preserving and printing the temp directory during debug should be sufficient?
There was a problem hiding this comment.
this is the behavior that we have now (except printing which folder it is). I prefer to have --debug put the intermediate deployable in my cur-dir since it speeds up debugging, but it is a personal preference.
| """ | ||
| if self.path is not None and os.path.exists(self.path): | ||
| shutil.rmtree(self.path, ignore_errors=ignore_errors) |
There was a problem hiding this comment.
If in debug mode, maybe we can print the temp dir instead of removing.
|
closing this since we felt it would be better to print out the path for the intermediate bento instead of moving it to current path. #182 addresses the new change |
Description
closes: