Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

fix: pass the --load flag with buildx build to make result img available #187

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented Aug 9, 2022

Description

loads the final image build into system-wide docker. This fixes the docker image missing error when the docker buildx builder is a container-based one. @ssheng had experienced this issue on his system
closes:

@jjmachan jjmachan requested a review from aarnphm August 9, 2022 14:02
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #187 (dcf5ef2) into main (a3471f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   59.05%   59.05%           
=======================================
  Files          24       24           
  Lines        1138     1138           
=======================================
  Hits          672      672           
  Misses        466      466           
Flag Coverage Δ
unit-tests 59.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/docker_utils.py 24.65% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

aarnphm
aarnphm previously approved these changes Aug 9, 2022
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catchiing this.

bentoctl/docker_utils.py Outdated Show resolved Hide resolved
ssheng
ssheng previously approved these changes Aug 11, 2022
@ssheng
Copy link
Contributor

ssheng commented Aug 11, 2022

Looks like there are lint and format error. Please address and merge. @jjmachan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants