Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

feat(config): add env block to deployment config #196

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Sep 30, 2022

Description

See here for context: bentoml/google-cloud-run-deploy#21 (comment)

UI:

Select y:
image
Enter BENTOML_CONFIG_OPTIONS:
image
Enter api_server.workers=1:
image
Select n:
image
image

closes:

@judahrand
Copy link
Contributor Author

@ssheng @jjmachan How does this look to you both as an interface for including env in the deployment_config.yaml?

ssheng
ssheng previously approved these changes Oct 2, 2022
@judahrand
Copy link
Contributor Author

I'll fix the tests when I get the chance. Didn't want to put the effort in until I knew the UI approach was reasonable/acceptable.

@ssheng
Copy link
Contributor

ssheng commented Oct 2, 2022

@judahrand, there are maybe a few places in the unit tests that needed to be updated. Could you please help fix them when you get a chance?

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #196 (f7571d0) into main (68574bc) will increase coverage by 0.68%.
The diff coverage is 97.22%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   59.05%   59.73%   +0.68%     
==========================================
  Files          24       22       -2     
  Lines        1138     1150      +12     
==========================================
+ Hits          672      687      +15     
+ Misses        466      463       -3     
Flag Coverage Δ
unit-tests 59.73% <97.22%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/deployment_config.py 71.52% <94.73%> (+3.02%) ⬆️
bentoctl/cli/interactive.py 92.15% <100.00%> (+0.78%) ⬆️
bentoctl/__init__.py
bentoctl/utils/__init__.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bentoctl/cli/__init__.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants