Fix variants not working #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't add variants to @Keyframe selectors, because tailwind will complain 'Variant cannot be generated because selector contains no classes', so we need to make two calls to addUtilities.
We don't actually need to call variants() inside our returned function, because that looks up the variants element in the main tailwind config object, and according to the README, the way to use this lib is to pass the variants directly. Besides, the destructured variants was shadowing the 'variants' array passed in by the user, so it was never used.
In trying to keep the README unmodified, we accept the passed in options object and destructure it. Before, the variants were passed in as part of the object, but they were ignored, because in the function signature the 'variants' argument was outside of the (now destructured) object.
|
Nice, big thank for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that variants weren't working, so I made a few changes and now they work.
variants()function that tailwind provides.['responsive']argument would be used, but that one was also ignored, because of shadowing by the destructuredvarianthelper function by tailwind