Repository navigation
feat: bar charts - #39
feat: bar charts #39
Conversation
|
Man that looks so much better (with some tiny style issues to be resolved). I'll poke at this sometime this week. 🙏 |
|
So I took a peek at this: I'd like to figure out how to achieve the result without adding empty table cells. Mostly for a11y; the markup should reflect the content. I'm playing around with it now. We're also free to edit |
|
I merged your PR then re-did how the colors were applied to drop the extra |
|
Also added #42 |
Aha, that was confusing me lots! Nice, thanks for fixing and merging🎉 |
* feat: implements bar charts * fix hydration errors causing select to break * fix: comment typo --------- Co-authored-by: Ben Vinegar <2153+benvinegar@users.noreply.github.com>
Resolves: #28
Notes:
Was slightly trickier than anticipated because because absolute positioning elements in a css table is much harder than with plain divs in a css grid. Down the line I do wonder if if its worth refactoring the table component be plain divs and css grid if the component gets more complex, would give a bit more css flexiblity but at the cost of good html semantics.
Demo: https://counterscale.chiubaca.workers.dev/dashboard