Retry media load if it has Infinity duration. #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielr18 how does this look? |
benwiley4000
force-pushed
the
issue/355-ios-infinity-duration
branch
from
42f0133
to
f7817e9
Compare
benwiley4000
force-pushed
the
issue/355-ios-infinity-duration
branch
from
f7817e9
to
0dafa44
Compare
|
Update.. I tested with a different radio source I found on the internet which takes some time to connect (http://live96.917xfm.de/;stream;audio.mp3?hash=1419274099574) and the difference is substantial. It takes twice as long to load (from ~3.5 to ~7 seconds) with the infinity duration guard. So I've added a new track property called I'm marking this as a breaking change since it's necessary to set that property in order to get the same loadtime performance if you're playing live streams. |
|
Released in v2.0.0-alpha.27 (has breaking changes, see the release notes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355.
Tested with an infinite duration stream and
it seems to not have any noticeable impact on playback(http://158.69.114.190:8072/;?1476089829845.mp3, which I found on a site that uses Cassette for radio playback: https://arubapage.com).