Restore focus to item that was focused before opening palette #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2023 20:47
When the palette opens, it steals focus from the underlying page. This change records the focused element before opening the modal. Then on onClose it restores the focus to the element.
Activating the palette using the mobile button doesn't set focusedElement from document.activeElement. Even if it did, the button becomes the activeElement. Not exactly useful. Set up a focus handler that looks at event.relatedTarget and use the relatedTarget as the focusedElement if it can be focused. If relatedTarget is null, use document.body. also if focusedElement is falsy, console.error it. Also added a period at the end of the title for the button in MobileButton. It makes voice reading work better.
Missed this.
benwinding
approved these changes
Feb 11, 2023
|
Arguably it could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the palette opens, it steals focus from the underlying page. This change records the focused element before opening the modal. Then on onClose it restores the focus to the element.
This happens regardless of the state of hotkeysGlobal, but is only really noticeable when you invoke command-pal
from a control.